-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): automate E2E scenario with use of Operator for installation refactored #2088
chore(e2e): automate E2E scenario with use of Operator for installation refactored #2088
Conversation
Skipping CI for Draft Pull Request. |
d4418d2
to
11adc29
Compare
/test e2e-tests |
/test images |
The image is available at: |
The image is available at: |
a3fe8d0
to
30bfec6
Compare
/test e2e-tests |
The image is available at: |
/test e2e-tests |
The image is available at: |
6457fd1
to
df06fd7
Compare
/test e2e-tests |
The image is available at: |
df06fd7
to
23518a1
Compare
/test e2e-tests |
/test all |
The image is available at: |
d399fa4
to
b401b4c
Compare
/test all |
The image is available at: |
b401b4c
to
551622a
Compare
/test all |
The image is available at: |
551622a
to
ff6b882
Compare
/test all |
/test all |
The image is available at: |
5e260b9
to
30c984a
Compare
/test all |
30c984a
to
bb38d85
Compare
/test all |
The image is available at: |
/retest |
bb38d85
to
b29d716
Compare
The image is available at: |
/restest |
/retest |
1 similar comment
/retest |
b29d716
to
2c3160f
Compare
The image is available at: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdrapela The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
49f115e
into
redhat-developer:main
apply_yaml_files "${DIR}" "${NAME_SPACE}" | ||
deploy_test_backstage_provider "${NAME_SPACE}" | ||
API_SERVER_URL=$(oc whoami --show-server) | ||
ENCODED_API_SERVER_URL=$(echo "${API_SERVER_URL}" | base64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use K8S_CLUSTER_API_SERVER_URL
env that holds same value.
deploy_test_backstage_provider "${NAME_SPACE}" | ||
API_SERVER_URL=$(oc whoami --show-server) | ||
ENCODED_API_SERVER_URL=$(echo "${API_SERVER_URL}" | base64) | ||
ENCODED_CLUSTER_NAME=$(echo "my-cluster" | base64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in env we have ENCODED_CLUSTER_NAME
you may use that. its same.
namespace: showcase-operator-nightly | ||
- kind: ServiceAccount | ||
name: rhdh-k8s-plugin | ||
namespace: showcase-op-rbac-nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this config is required for ocm test case and that only runs in showcase not on showcase-rbac, so you may remove showcase-op-rbac-nightly
namespace.
@@ -14,6 +14,8 @@ | |||
"showcase-rbac-nightly": "playwright test --project=showcase-rbac", | |||
"showcase-k8s-ci-nightly": "playwright test --project=showcase-k8s", | |||
"showcase-rbac-k8s-ci-nightly": "playwright test --project=showcase-rbac-k8s", | |||
"showcase-operator-nightly": "playwright test --project=showcase-operator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we are expected to run all the tests that we use on Helm deployment on the operator as well. It makes sense to call playwright test --project=showcase
and playwright test --project=showcase-rbac
instead of adding a new project in config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is similar to k8s tests. Some of the tests are not yet adapted to work on Operator and until then we need to add them to testIgnore
thus we need another project.
Even after we achieve the parity of tests for Operator and Helm, we can have some of the tests start to fail on one of them, and we will have to temporarily disable it. Better to do that just for the Operator than skip the test for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with the plan. Are there JIRA tickets just for tracking the skipped test cases, so we don't miss them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened this JIRA ticket for the operator https://issues.redhat.com/browse/RHIDP-5366.
Description
automate E2E scenario with use of Operator for installation refactored
Which issue(s) does this PR fix
RHIDP-5227
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer