Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): automate E2E scenario with use of Operator for installation refactored #2088

Conversation

Omar-AlJaljuli
Copy link
Contributor

Description

automate E2E scenario with use of Operator for installation refactored

Which issue(s) does this PR fix

RHIDP-5227

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Dec 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests

@Omar-AlJaljuli
Copy link
Contributor Author

/test images

Copy link
Contributor

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests
/test images

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests
/test images

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests
/test images

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test e2e-tests
/test images

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

@Omar-AlJaljuli
Copy link
Contributor Author

/test all

Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

@Omar-AlJaljuli Omar-AlJaljuli marked this pull request as ready for review December 16, 2024 02:45
@Omar-AlJaljuli Omar-AlJaljuli requested a review from a team as a code owner December 16, 2024 02:45
@Omar-AlJaljuli Omar-AlJaljuli changed the title [WIP] chore(e2e): automate E2E scenario with use of Operator for installation refactored chore(e2e): automate E2E scenario with use of Operator for installation refactored Dec 16, 2024
Copy link
Contributor

@Omar-AlJaljuli
Copy link
Contributor Author

/restest

@Omar-AlJaljuli
Copy link
Contributor Author

/retest

1 similar comment
@Omar-AlJaljuli
Copy link
Contributor Author

/retest

Copy link
Contributor

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdrapela

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 49f115e into redhat-developer:main Dec 16, 2024
12 checks passed
apply_yaml_files "${DIR}" "${NAME_SPACE}"
deploy_test_backstage_provider "${NAME_SPACE}"
API_SERVER_URL=$(oc whoami --show-server)
ENCODED_API_SERVER_URL=$(echo "${API_SERVER_URL}" | base64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use K8S_CLUSTER_API_SERVER_URL env that holds same value.

deploy_test_backstage_provider "${NAME_SPACE}"
API_SERVER_URL=$(oc whoami --show-server)
ENCODED_API_SERVER_URL=$(echo "${API_SERVER_URL}" | base64)
ENCODED_CLUSTER_NAME=$(echo "my-cluster" | base64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in env we have ENCODED_CLUSTER_NAME you may use that. its same.

namespace: showcase-operator-nightly
- kind: ServiceAccount
name: rhdh-k8s-plugin
namespace: showcase-op-rbac-nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config is required for ocm test case and that only runs in showcase not on showcase-rbac, so you may remove showcase-op-rbac-nightly namespace.

@@ -14,6 +14,8 @@
"showcase-rbac-nightly": "playwright test --project=showcase-rbac",
"showcase-k8s-ci-nightly": "playwright test --project=showcase-k8s",
"showcase-rbac-k8s-ci-nightly": "playwright test --project=showcase-rbac-k8s",
"showcase-operator-nightly": "playwright test --project=showcase-operator",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are expected to run all the tests that we use on Helm deployment on the operator as well. It makes sense to call playwright test --project=showcase and playwright test --project=showcase-rbac instead of adding a new project in config.

Copy link
Contributor

@zdrapela zdrapela Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is similar to k8s tests. Some of the tests are not yet adapted to work on Operator and until then we need to add them to testIgnore thus we need another project.
Even after we achieve the parity of tests for Operator and Helm, we can have some of the tests start to fail on one of them, and we will have to temporarily disable it. Better to do that just for the Operator than skip the test for both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the plan. Are there JIRA tickets just for tracking the skipped test cases, so we don't miss them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened this JIRA ticket for the operator https://issues.redhat.com/browse/RHIDP-5366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants