Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix droute failing to send results on 1st try #2146

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Jan 6, 2025

Description

Data Router (droute) is failing to send the test results on the first try. This PR adds the retry, which seems to work fine (the second retry is usually successful).

This also adds verbose logging and recommended troubleshooting steps.

Related to discussion here: https://redhat-internal.slack.com/archives/C06Q4M84XDG/p1734598673170759

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@zdrapela zdrapela requested a review from a team as a code owner January 6, 2025 15:24
@zdrapela zdrapela mentioned this pull request Jan 6, 2025
5 tasks
@zdrapela zdrapela force-pushed the droute-fix-fail-to-send-first branch 3 times, most recently from fe6b03d to 84a5494 Compare January 6, 2025 15:28
@zdrapela zdrapela marked this pull request as draft January 6, 2025 15:30
@zdrapela zdrapela force-pushed the droute-fix-fail-to-send-first branch from 84a5494 to dabfd23 Compare January 6, 2025 15:32
@zdrapela zdrapela marked this pull request as ready for review January 6, 2025 15:32
@openshift-ci openshift-ci bot requested a review from josephca January 6, 2025 15:32
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Copy link
Collaborator

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7bc7354 into redhat-developer:main Jan 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants