chore(ci): build images from tags, build next nightly #2218
Conversation
|
The image is available at: |
kadel
changed the title
|
The image is available at: |
|
|
||
| on: | ||
| schedule: | ||
| # run at 3:18 UTC every day | ||
| - cron: "18 3 * * *" |
There was a problem hiding this comment.
I'm confused why you want to switch from "on every push to main" to "once a day"... are we trying to reduce noise ? server usage? data centre heat causing global warming?
There was a problem hiding this comment.
If you do "on every push to main" than every time, there is a new commit on main, the running job gets canceled, and a new one is trigerred. Which makes sense because otherwise you are building something that is already out of date.
To complete a full multiplatform image build, which typically takes over 5 hours, you’d need at least five consecutive hours without merging any pull requests (PRs) into main.
During regular workdays, with multiple PRs being merged daily, this job will likely get triggered and canceled repeatedly until nighttime when there’s less activity.
There was a problem hiding this comment.
FIVE HOURS? What's it doing, compiling every single dependent package from sources??
There was a problem hiding this comment.
also you can turn off the concurrency settings to cancel in-progress builds if you don't want things to be cancelled and started over:
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
There was a problem hiding this comment.
yes, but if we don't cancel it than we are building something that is is never going to be used
There was a problem hiding this comment.
FIVE HOURS? What's it doing, compiling every single dependent package from sources??
arm build takes this long becuase it is running in emualated environment
|
The image is available at: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
|
/hold lets get agreement that everyone is ok with switching to daily builds |
|
+1 on the changes |
Co-authored-by: Armel Soro <armel@rm3l.org>
|
The image is available at: |
|
/hold cancel |
|
The image is available at: |
openshift-merge-bot
bot
merged commit fa2e216
into
redhat-developer:main
Modifies .github/workflows/next-build-image.yaml
related to https://issues.redhat.com/browse/RHIDP-5027