Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Backstage to 1.34.2 #2219

Closed
wants to merge 10 commits into from
Closed

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Jan 21, 2025

Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from 04kash. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

janus-idp bot and others added 10 commits January 21, 2025 09:29
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
…json

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
…ort-dynamic command in some wrappers

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@04kash 04kash force-pushed the dependencies/backstage-1.34 branch from 3f88be1 to 2b3a3b2 Compare January 21, 2025 14:29
@04kash 04kash self-assigned this Jan 21, 2025
Copy link
Contributor

@04kash
Copy link
Collaborator Author

04kash commented Jan 21, 2025

/retest

Copy link

openshift-ci bot commented Jan 21, 2025

@04kash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 2b3a3b2 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@04kash
Copy link
Collaborator Author

04kash commented Jan 21, 2025

When I tested locally, I was able to successfully test the homepage and tech radar plugins. I will try testing on a cluster as well. cc: @josephca

@04kash 04kash requested review from schultzp2020 and removed request for dzemanov and its-mitesh-kumar January 21, 2025 18:12
@04kash 04kash force-pushed the dependencies/backstage-1.34 branch from d141570 to 2b3a3b2 Compare January 21, 2025 23:00
@04kash 04kash marked this pull request as draft January 21, 2025 23:06
@04kash 04kash removed the request for review from schultzp2020 January 21, 2025 23:06
Copy link
Contributor

@04kash
Copy link
Collaborator Author

04kash commented Jan 22, 2025

Closing in favour of #2220 (Will directly move to 1.35)

@04kash 04kash closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant