Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(plugins): bump dynamic wrappers to latest .y versions (RHIDP-5317) #2253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(plugins): bump dynamic wrappers to latest .y versions (RHIDP-5317) #2253

wants to merge 3 commits into from

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Jan 25, 2025 •
edited by openshift-ci bot
Loading

What does this PR do?

chore(plugins): bump dynamic wrappers to latest .y versions (RHIDP-5317)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@04kash
Copy link
Collaborator

04kash commented Jan 27, 2025

Looks like the turbo.json file is missing from the wrapper for red-hat-developer-hub-backstage-plugin-global-header (https://github.com/redhat-developer/rhdh/tree/main/dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-global-header)

@nickboldt nickboldt changed the title chore(plugins): bump dynamic wrappers to... chore(plugins): bump dynamic wrappers to latest .y versions (RHIDP-5317) Jan 27, 2025
@nickboldt
Copy link
Member Author

Looks like the turbo.json file is missing from the wrapper for red-hat-developer-hub-backstage-plugin-global-header (https://github.com/redhat-developer/rhdh/tree/main/dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-global-header)

Added in #2268

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@04kash
Copy link
Collaborator

04kash commented Jan 31, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 04kash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Member Author

/test e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Feb 7, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 7, 2025

New changes are detected. LGTM label has been removed.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

The image is available at:

@nickboldt
chore(plugins): bump dynamic wrappers to latest .y versions (RHIDP-5317)
12c2650 
Signed-off-by: Nick Boldt <nboldt@redhat.com>

add --shared-package  \!@backstage/backend-common to dynamic-plugins/wrappers/red-hat-developer-hub-backstage-plugin-marketplace-backend-dynamic/package.json

Signed-off-by: Nick Boldt <nboldt@redhat.com>

add --suppress-native-package and update the marketplace catalog backend module export flags (#2277)

Signed-off-by: Stan Lewis <gashcrumb@gmail.com>

run ./scripts/update-dynamic-plugins-wrappers.sh --minor --force

Signed-off-by: Nick Boldt <nboldt@redhat.com>

regen yarn lock again

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt
revert changes to @backstage-community/plugin-rbac; stay on 1.33.4 un…
031f9af 
…til Patrick fixes the e2e issue

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt
regen
f9c9882 
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 7, 2025

@nickboldt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/periodic-e2e-tests-aks-helm-nightly eed6654 link false /test periodic-e2e-tests-aks-helm-nightly
ci/prow/periodic-e2e-tests-gke-helm-nightly 1aba657 link false /test periodic-e2e-tests-gke-helm-nightly
ci/prow/e2e-tests f9c9882 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzemanov dzemanov Awaiting requested review from dzemanov

@its-mitesh-kumar its-mitesh-kumar Awaiting requested review from its-mitesh-kumar

@gashcrumb gashcrumb Awaiting requested review from gashcrumb

@schultzp2020 schultzp2020 Awaiting requested review from schultzp2020

@04kash 04kash Awaiting requested review from 04kash

Assignees

@04kash 04kash

Labels
approved needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickboldt @04kash @openshift-merge-robot