Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Commit

Permalink
refactor: 💡 add note to change the logic in updateVolumes()
Browse files Browse the repository at this point in the history
  • Loading branch information
Igor Sutton Lopes committed Apr 17, 2020
1 parent 5bbecf4 commit 7d0efec
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/controller/servicebindingrequest/binder.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ import (
"context"
"errors"
"fmt"
"time"

"k8s.io/apimachinery/pkg/fields"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/runtime/schema"
"time"

"gotest.tools/assert/cmp"
corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -141,6 +142,8 @@ func (b *Binder) removeSpecVolumes(
func (b *Binder) updateVolumes(volumes []interface{}) ([]interface{}, error) {
name := b.sbr.GetName()
log := b.logger

// FIXME(isuttonl): update should not bail out here since b.volumeKeys might change
log.Debug("Checking if binding volume is already defined...")
for _, v := range volumes {
volume := v.(corev1.Volume)
Expand Down

0 comments on commit 7d0efec

Please sign in to comment.