Custom environment variables should not be prefixed with global prefix

[isutton]

#407 has unwillingly changed the behavior of custom environment variables, by prefixing those with the global environment variable prefix if informed.

This behavior should be reverted.

For reference, see #475 (comment).

[sbose78]

Could you please summarize the issue here?

[DhritiShikhar]

@isutton

Is this a duplicate of #475 ?

[Avni-Sharma]

Hi @isutton Do we remove the global envVarPrefix and service's envVarPrefix both, or only the global envVarPrefix? IMO both should be removed, as the custom name should be independent of any prefix as it is custom, however, the issue just mentions Global Prefix, so wanted confirmation in the same regard.

[isutton]

@Avni-Sharma

Hi @isutton Do we remove the global envVarPrefix and service's envVarPrefix both, or only the global envVarPrefix? IMO both should be removed, as the custom name should be independent of any prefix as it is custom, however, the issue just mentions Global Prefix, so wanted confirmation in the same regard.

You're right.

I've just mentioned the global envVarPrefix because service's envVarPrefix doesn't apply to values applied to customEnvVar/dataMapping; an entry in customEnvVar/dataMapping might refer to no services (in the case there's no interpolation in the template) or many services (in the case values from several services are interpolated).

[Avni-Sharma]

Thanks @isutton