-
Notifications
You must be signed in to change notification settings - Fork 89
make custom_env_var can reference the whole secret/configmap without using a slash #521
make custom_env_var can reference the whole secret/configmap without using a slash #521
Conversation
Hi @qibobo. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6a4cb89
to
38164bc
Compare
38164bc
to
a7b8dac
Compare
@isutton I have rebase the code with master and verified the feature works.
2 create knative service as application
3 Create SBR
4 Check env injection:
|
/test |
@isutton: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/ok-to-test |
/retest |
@isutton , the test seems passed |
@DhritiShikhar @isutton , can you help to review? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isutton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is to fix the issue we reported in #475 (comment).
@isutton
Could you take a look at this PR? It need to be rebased after your PR #515 is merged.