This repository has been archived by the owner on May 11, 2022. It is now read-only.
FUSETOOLS2-930 - smarter caching #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>
|
This was meant to address the issue on Che/Theia returning an error, but turned into a way to look at where we should cache these files. I suspect we should maybe shift to just use the workspace location rather than the global one to simplify things for Che and standard VS Code, but I'm not sure. |
|
Closing this as no longer needed after #365 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian Fitzpatrick bfitzpat@redhat.com
Meant to address
cannot read property fsPath of undefinedissue when reading from cacheApparently the global or workspace uri locations are not defined in theia - Artem opened eclipse-theia/theia#8883
In this case, we are simply trying both the global and workspace locations