Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor activate() to use await #2906

Open
datho7561 opened this issue Jan 27, 2023 · 0 comments · May be fixed by #2910
Open

Refactor activate() to use await #2906

datho7561 opened this issue Jan 27, 2023 · 0 comments · May be fixed by #2910
Labels
build/infra debt

Comments

@datho7561
Copy link
Contributor

Refactor the activate function (main entry point to extension) to use await instead of promise chaining and promise constructors.

Why?

  • The async logic is currently really hard to read
  • The function is > 300 lines of code, and using async could make it shorter
  • The function contains async promise executors, which are considered bad since they make error handling hard
@datho7561 datho7561 added the debt label Jan 27, 2023
This was referenced Jan 27, 2023
Merged
Open
datho7561 added a commit to datho7561/vscode-java that referenced this issue Jan 30, 2023
@datho7561
Refactor activate() to use await
b2a4279 
Closes redhat-developer#2906

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/vscode-java that referenced this issue Feb 8, 2023
@datho7561
Refactor activate() to use await
f703482 
Closes redhat-developer#2906

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build/infra debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor activate() to use await datho7561/vscode-java
2 participants
@testforstephen @datho7561