Return the API before importing the projects #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
commented
Jan 27, 2023
datho7561
force-pushed
the
2900-return-extension-api-earlier
branch
from
3e25759 to
ccb426c
Compare
datho7561
commented
Jan 27, 2023
datho7561
force-pushed
the
2900-return-extension-api-earlier
branch
from
ccb426c to
5b52f36
Compare
|
Yup, the underlying issue here was definitely a startup issue. Wouldn't be surprised if we hit it now because VS Code started properly waiting for extension activation. The early |
datho7561
force-pushed
the
2900-return-extension-api-earlier
branch
3 times, most recently
from
761a9a2 to
b8162c2
Compare
This also has the side effect that extensions that depend on vscode-java can start up sooner. Fixes redhat-developer#2900 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
2900-return-extension-api-earlier
branch
from
b8162c2 to
f7d75e7
Compare
jdneo
approved these changes
Jan 30, 2023
rgrunber
reviewed
Jan 30, 2023
|
@jdneo I'll merge this. I would just keep an eye on any extension tests that may depend on this, or any places that make any assumptions about the state of the language server through the api manager immediately on startup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also has the side effect that extensions that depend on vscode-java can start up sooner.
Fixes #2900
Signed-off-by: David Thompson davthomp@redhat.com