Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors when configuring a wrong runtime path #1625

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

testforstephen
Copy link
Collaborator

@testforstephen testforstephen commented Sep 18, 2020

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

It requires eclipse-jdtls/eclipse.jdt.ls#1550
Fix #1614, Fix #1568, Fix #1481

It will validate the java.configuration.runtimes settings in both cases below. Meanwhile provide a regular pattern to check whether the path contains bin.

  • The Java extension is activated.
  • java.configuration.runtimes settings are changed.

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@testforstephen
Copy link
Collaborator Author

image

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@fbricon fbricon merged commit 8348f61 into redhat-developer:master Sep 28, 2020
@testforstephen testforstephen deleted the jinbo_runtime branch September 28, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants