Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pasting a java file in the file explorer #3404

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

hopehadfield
Copy link
Contributor

Addresses #3323

Introduces new keybinding and command for pasting a java file into the file explorer. Relies on delegate command introduced in eclipse-jdtls/eclipse.jdt.ls#2981.

@hopehadfield hopehadfield force-pushed the file-explorer-paste branch 2 times, most recently from 75f5b00 to 245657f Compare November 29, 2023 20:23
@rgrunber rgrunber self-requested a review November 29, 2023 20:42
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I have yet to test, and will look more closely at pasteFile.

src/pasteAction.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/pasteAction.ts Outdated Show resolved Hide resolved
src/pasteAction.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@hopehadfield hopehadfield force-pushed the file-explorer-paste branch 2 times, most recently from b8c9a89 to 794be54 Compare December 1, 2023 21:10
package.json Outdated Show resolved Hide resolved
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, change looks good on this end is ready to merge. I just need to verify the language server part.

src/pasteAction.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@hopehadfield hopehadfield force-pushed the file-explorer-paste branch 2 times, most recently from a268637 to 6f065cd Compare December 8, 2023 16:45
src/pasteAction.ts Outdated Show resolved Hide resolved
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@rgrunber rgrunber merged commit 72a6b03 into redhat-developer:master Dec 14, 2023
2 checks passed
@hopehadfield hopehadfield deleted the file-explorer-paste branch December 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants