Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow loading of the OpenShift explorer caused by duplicate oc commands #4289 #4300

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Slow loading of the OpenShift explorer caused by duplicate oc commands #4289 #4300

merged 1 commit into from
Jul 19, 2024

Conversation

vrubezhny
Copy link
Contributor

Fixes: #4289

@vrubezhny vrubezhny force-pushed the fix-app-explorer-refresh-is-slow branch from 6afdc78 to ad737b5 Compare July 18, 2024 20:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.28926% with 42 lines in your changes missing coverage. Please review.

Project coverage is 43.94%. Comparing base (da60441) to head (d90aabc).
Report is 381 commits behind head on main.

Files Patch % Lines
src/explorer.ts 39.13% 14 Missing ⚠️
src/serverlessFunction/functions.ts 31.57% 13 Missing ⚠️
src/cli.ts 73.33% 4 Missing ⚠️
src/oc/ocWrapper.ts 82.60% 4 Missing ⚠️
src/openshift/openshiftItem.ts 75.00% 4 Missing ⚠️
src/serverlessFunction/knative.ts 66.66% 1 Missing ⚠️
src/tekton/tekton.ts 66.66% 1 Missing ⚠️
src/util/kubeUtils.ts 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4300       +/-   ##
===========================================
+ Coverage   32.37%   43.94%   +11.57%     
===========================================
  Files          85       95       +10     
  Lines        6505     7732     +1227     
  Branches     1349     1641      +292     
===========================================
+ Hits         2106     3398     +1292     
+ Misses       4399     4334       -65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datho7561
datho7561 requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix, but otherwise is working amazingly!

src/cli.ts Outdated Show resolved Hide resolved
@vrubezhny vrubezhny force-pushed the fix-app-explorer-refresh-is-slow branch from ad737b5 to 7899420 Compare July 19, 2024 18:04
datho7561
datho7561 previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Thanks, Victor!

@vrubezhny vrubezhny force-pushed the fix-app-explorer-refresh-is-slow branch from 7899420 to d90aabc Compare July 19, 2024 18:18
@vrubezhny vrubezhny requested a review from datho7561 July 19, 2024 18:19
@vrubezhny vrubezhny merged commit 767f770 into redhat-developer:main Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

@fbricon fbricon Awaiting requested review from fbricon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow loading of the OpenShift explorer caused by duplicate oc commands
3 participants
@vrubezhny @codecov-commenter @datho7561