-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activation trigger should be more selective #497
Comments
I think the easiest approach would be to make the extension activation a kind of "silent" activation that only starts the necessary language servers if the Maven/Gradle build files indicate they support Quarkus. This seems the easiest option. The problem with the |
- Fixes redhat-developer#497 - Only start language server(s) and contribute extension functionality if a Quarkus project is detected Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer#497 - Only start language server(s) and contribute extension functionality if a Quarkus project is detected Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes redhat-developer#497 - Only start language server(s) and contribute extension functionality if a Quarkus project is detected Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
- Fixes #497 - Only start language server(s) and contribute extension functionality if a Quarkus project is detected Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
The Quarkus extension and language server are triggered for
onLanguage:java
. This seems excessive. I can have an invisible project with just folders and Java source files (no Maven, no Gradle), and it still starts.At the very least we could bring it down to just :As for a better approach, maybe vscode-java could define some command that reads the build files for presence of Quarkus metadata (eg. quarkus-bom, quarkus-maven-plugin, io.quarkus.extension, etc), and emit some command for which vscode-quarkus simply listens with https://code.visualstudio.com/api/references/activation-events#onCommand
The text was updated successfully, but these errors were encountered: