Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request failed on every java file load #586

Closed
maxandersen opened this issue Feb 27, 2023 · 2 comments · Fixed by #589
Closed

request failed on every java file load #586

maxandersen opened this issue Feb 27, 2023 · 2 comments · Fixed by #589
Assignees
@datho7561
Labels
bug Something isn't working
Milestone
1.13.0

Comments

@maxandersen
Copy link
Collaborator

I get a notification saying requests failed.

log has this in Qute support view:

[Error - 8:17:32 PM] Request textDocument/inlayHint failed.
[object Object]
[Error - 8:17:33 PM] Request textDocument/inlayHint failed.
[object Object]
[Error - 8:17:34 PM] Request textDocument/inlayHint failed.
[object Object]
[Error - 8:17:34 PM] Request textDocument/inlayHint failed.
[object Object]
[Error - 8:17:34 PM] Request textDocument/inlayHint failed.
[object Object]
@angelozerr
Copy link
Contributor

I think this issue should be fixed in master which uses the last version of vscode language client.

Could you please install prerelease of vscode microprofile and quarkus please.

@datho7561
Copy link
Contributor

I think this is related to the API change I did in vscode-java. @angelozerr I think we need to make sure the java language server is in standard mode before sending delegate commands to it. (I'll look into making this change today).

@datho7561 datho7561 mentioned this issue Feb 27, 2023
Merged
datho7561 added a commit to datho7561/vscode-quarkus that referenced this issue Feb 27, 2023
@datho7561
Wait on jdt.ls standard mode before issuing delegate commands
a0c4755 
Use the API to wait until jdt.ls is running before issuing commands to it.
This bug is happening, since jdt.ls is no longer guaranteed
to be running when vscode-quarkus launches.

Fixes redhat-developer#586

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 self-assigned this Feb 27, 2023
@datho7561 datho7561 added the bug Something isn't working label Feb 27, 2023
@datho7561 datho7561 moved this to 👀 In review in IDE Cloudaptors Feb 27, 2023
@datho7561 datho7561 added this to the 1.13.0 milestone Feb 28, 2023
datho7561 added a commit that referenced this issue Feb 28, 2023
@datho7561
Wait on jdt.ls standard mode before issuing delegate commands
e471e87 
Use the API to wait until jdt.ls is running before issuing commands to it.
This bug is happening, since jdt.ls is no longer guaranteed
to be running when vscode-quarkus launches.

Fixes #586

Signed-off-by: David Thompson <davthomp@redhat.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working
Projects
IDE Cloudaptors
Archived in project
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Wait on jdt.ls standard mode before issuing delegate commands datho7561/vscode-quarkus
3 participants
@maxandersen @angelozerr @datho7561