Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved syntax coloration for operator support for #if #480

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Improved syntax coloration for operator support for #if #480

merged 1 commit into from
Apr 7, 2022

Conversation

AlexXuChen
Copy link
Contributor

Improved syntax colouration for operator support for #if based on https://quarkus.io/guides/qute-reference#if_section, and separated by precedence.

Fixes #478

Signed-off-by: Alexander Chen alchen@redhat.com

@angelozerr angelozerr changed the title Improved syntax colouration for operator support for #if Improved syntax coloration for operator support for #if Mar 30, 2022
@AlexXuChen AlexXuChen force-pushed the issue478 branch 3 times, most recently from bc6e472 to 8e112dc Compare April 1, 2022 19:16
@AlexXuChen AlexXuChen force-pushed the issue478 branch 3 times, most recently from e51ecd9 to a13c5a2 Compare April 5, 2022 18:06
@angelozerr
Copy link
Contributor

If you write

{#if a orXXX b}
  
{/if}

or is higlighted as a keyword although it should not (orXXX should have the same color).

image

@angelozerr
Copy link
Contributor

The in in #for is not colorized as keyword:

image

@AlexXuChen
Copy link
Contributor Author

@angelozerr I added word boundaries, so should work properly now:
image

Improved syntax colouration for operator support for #if
9cb5458 
Signed-off-by: Alexander Chen <alchen@redhat.com>
@angelozerr angelozerr merged commit a701d51 into redhat-developer:master Apr 7, 2022
@angelozerr
Copy link
Contributor

It works like a charm, great job @AlexXuChen !

@AlexXuChen AlexXuChen deleted the issue478 branch April 7, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelozerr angelozerr Awaiting requested review from angelozerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax coloration for operator support for #if
2 participants
@AlexXuChen @angelozerr