Migrate from find-java-home to jdk-utils #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to replace the repository.engineering.redhat.com/nexus/repository URLS in the package-lock.json with the corresponding npm ones, so that non-Red Hat developers working on this project can download the dependencies. (you should be able to do this with a quick search and replace). |
|
Other than what I mentioned, this PR looks good. It should probably never need to be run, since vscode-java ships with a JDK on most platforms, and if vscode-java doesn't detect a JDK, then it won't launch, which should prevent vscode-quarkus from launching. |
JessicaJHee
force-pushed
the
569-migrate-find-java-home
branch
2 times, most recently
from
28e43ef
to
acb016c
Compare
Signed-off-by: Jessica He <jhe@redhat.com>
datho7561
requested changes
Jan 26, 2023
JessicaJHee
force-pushed
the
569-migrate-find-java-home
branch
from
acb016c
to
5412b05
Compare
datho7561
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Signed-off-by: Jessica He jhe@redhat.com