Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vulnerable pom-parser with fast-xml-parser in tests, and other updates #657

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Feb 5, 2024

Signed-off-by: Fred Bricon fbricon@gmail.com

src/test/vscodeTest/suite/index.ts Outdated Show resolved Hide resolved
@fbricon fbricon force-pushed the fast-xml-parser branch 3 times, most recently from a42d787 to bc69f39 Compare February 5, 2024 15:51
package.json Show resolved Hide resolved
@fbricon fbricon force-pushed the fast-xml-parser branch 2 times, most recently from a5f447b to 0244481 Compare February 5, 2024 18:07
@fbricon
Copy link
Collaborator Author

fbricon commented Feb 5, 2024

tests finally pass

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge after this comment is addressed

package.json Outdated Show resolved Hide resolved
…r updates

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Fred!

@datho7561 datho7561 merged commit 7a8d707 into redhat-developer:master Feb 6, 2024
1 check passed
@datho7561 datho7561 modified the milestone: 1.17.0 Feb 6, 2024
@datho7561 datho7561 added the dependencies Pull requests that update a dependency file label Feb 6, 2024
@datho7561 datho7561 added this to the 1.18.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants