Replace axios with NodeJS 18 fetch()
#48
Conversation
|
@fbricon if you have time and think it's okay to drop support for versions before NodeJS 18, could you please take a look at this PR? |
|
It also needs to work in a browser. If that's not broken then I m fine with that on principle. Will check when I get back. |
|
Okay, thanks! |
`fetch()` works in the browser as well as NodeJS as of NodeJS 18. This PR requires upgrading to NodeJS 18. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
remove-axios
branch
from
a6938db
to
18377cd
Compare
|
@fbricon if you have some time could you please take a look at this PR? (no rush though) |
There was a problem hiding this comment.
I tried this out (with npm link) and it seems to be working well.
Unrelated to this PR, but I did run into conflicts between the @types/vscode defined in the extension I was testing (vscode-java) and vscode-redhat-telemetry when used with the linking approach. I don't remember running into this before when testing like that.
|
If this gets updated I won't have to update redhat-developer/vscode-java#3755 😜 |
|
thx @datho7561 |
fetch()works in the browser as well as NodeJS as of NodeJS 18. This PR requires upgrading to NodeJS 18.Signed-off-by: David Thompson davthomp@redhat.com