Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placing a / in an attribute triggers autoclosing to self-close the tag. #126

Closed
jmussman opened this issue Apr 14, 2019 · 0 comments · Fixed by eclipse-lemminx/lemminx#353
Closed

Placing a / in an attribute triggers autoclosing to self-close the tag. #126

jmussman opened this issue Apr 14, 2019 · 0 comments · Fixed by eclipse-lemminx/lemminx#353
Assignees
@NikolasKomonen
Labels
bug Something isn't working completion
Milestone
0.6.0

Comments

@jmussman
Copy link

In release 0.5.1 when autoclosing of tags is enabled, typing a / in a tag attribute, between quotation marks, self-closes the tag and throws any existing content away.

Make sure that autoclosing is enabled.
Start with: Some content
Add an attribute with a / to the tag: Some content
And it will be replaced with: <item x="/>

Note there is no closing quote left when this happens.
@fbricon fbricon added bug Something isn't working completion labels Apr 14, 2019
@fbricon fbricon added this to the 0.6.0 milestone Apr 14, 2019
@fbricon fbricon mentioned this issue Apr 18, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 18, 2019
@NikolasKomonen
Forward slash in bad places caused autoclose to break, and elements w…
8e803ec 
…ith capitals in their name

didn't autoclose

Fixes redhat-developer/vscode-xml#126 , eclipse-lemminx#354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 23, 2019
@NikolasKomonen
Forward slash in bad places caused autoclose to break, and elements w…
648a3c6 
…ith capitals in their name

didn't autoclose

Fixes redhat-developer/vscode-xml#126 , eclipse-lemminx#354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
fbricon pushed a commit to eclipse-lemminx/lemminx that referenced this issue Apr 24, 2019
@NikolasKomonen @fbricon
Fixed forward slash occasionally breaking autoclose
3168b2c 
... and autoclosing elements with capitals in their name

Fixes redhat-developer/vscode-xml#126 , #354

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
bug Something isn't working completion
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Forward slash in bad places caused autoclose to break NikolasKomonen/lsp4xml
3 participants
@fbricon @jmussman @NikolasKomonen