Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt .vscodeignore to the new path matching strategy #510

Closed
datho7561 opened this issue Jun 16, 2021 · 0 comments · Fixed by #511
Closed

Adapt .vscodeignore to the new path matching strategy #510

datho7561 opened this issue Jun 16, 2021 · 0 comments · Fixed by #511
Assignees
@datho7561
Labels
bug Something isn't working build
Milestone
0.17.0

Comments

@datho7561
Copy link
Contributor

vsce interprets the contents of .vscodeignore differently as of a recent change. This means that everything under docs/images is excluded from the .vsix (likely because of the rule images/). Adapt .vscodeignore so that everything that needs to be included is included.
@datho7561 datho7561 added bug Something isn't working build labels Jun 16, 2021
@datho7561 datho7561 added this to the 0.17.0 milestone Jun 16, 2021
datho7561 added a commit to datho7561/vscode-xml that referenced this issue Jun 16, 2021
@datho7561
Prevent docs/images from being excluded from .vsix
051bd19 
Fixes redhat-developer#510

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jun 16, 2021
Merged
@datho7561 datho7561 self-assigned this Jun 16, 2021
datho7561 added a commit that referenced this issue Jun 16, 2021
@datho7561
Prevent docs/images from being excluded from .vsix
da0ee09 
Fixes #510

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working build
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Prevent docs/images from being excluded from .vsix datho7561/vscode-xml
1 participant
@datho7561