Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to vscode-languageclient 8.0.1 #711

Closed
angelozerr opened this issue May 19, 2022 · 3 comments · Fixed by #712 or #860
Closed

Move to vscode-languageclient 8.0.1 #711

angelozerr opened this issue May 19, 2022 · 3 comments · Fixed by #712 or #860
Assignees
@angelozerr
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Milestone
0.24.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented May 19, 2022 •
edited
Loading

With vscode-languageclient 8.0.1, we will benefit with:

  • LSP 3.7 support
  • we could remove shouldLanguageServerExitOnShutdown
@angelozerr angelozerr self-assigned this May 19, 2022
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 19, 2022
@angelozerr
Move to vscode-languageclient 8.0.1
1c1a7e1 
Fixes redhat-developer#711

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 19, 2022
@angelozerr
Move to vscode-languageclient 8.0.1
ba1ff74 
Fixes redhat-developer#711

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue May 19, 2022
Merged
angelozerr added a commit that referenced this issue May 19, 2022
@angelozerr
Move to vscode-languageclient 8.0.1
ad42b24 
Fixes #711

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the 0.21.0 milestone May 19, 2022
@rgrunber rgrunber mentioned this issue May 25, 2022
Merged
@angelozerr angelozerr removed this from the 0.21.0 milestone Jun 29, 2022
@rgrunber
Copy link
Member

Can we prepare this for the 0.24.0 release ?

@rgrunber rgrunber reopened this Jan 17, 2023
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue Jan 20, 2023
@angelozerr
Move to vscode-languageclient 8.0.1
b5b98e6 
Fixes redhat-developer#711

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jan 20, 2023
Merged
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue Jan 23, 2023
@angelozerr
Move to vscode-languageclient 8.0.1
a44535a 
Fixes redhat-developer#711

Signed-off-by: azerr <azerr@redhat.com>
@datho7561 datho7561 added this to the 0.24.0 milestone Jan 23, 2023
@datho7561 datho7561 added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 23, 2023
datho7561 pushed a commit that referenced this issue Jan 23, 2023
@angelozerr @datho7561
Move to vscode-languageclient 8.0.1
825823c 
Fixes #711

Signed-off-by: azerr <azerr@redhat.com>
@vince-fugnitto
Copy link

I believe with the update to 8.0.1 the defined API version should be stepped to align, else it will fail to activate for older versions and applications that support the VS Code API:

vscode-xml/package.json

Lines 44 to 46 in efd52ad

"engines": {
"vscode": "^1.63.0"
},

The dependency vscode-languageclient@8.0.1 requires ^1.67.0:

@datho7561
Copy link
Contributor

Thanks for letting us know. I filed a bug to get this done

@datho7561 datho7561 mentioned this issue Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
IDE Cloudaptors
Archived in project
Milestone
0.24.0
4 participants
@rgrunber @angelozerr @datho7561 @vince-fugnitto