Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XInclude cannot be activated with binary mode #922

Closed
angelozerr opened this issue Jul 22, 2023 · 2 comments · Fixed by eclipse-lemminx/lemminx#1558
Closed

XInclude cannot be activated with binary mode #922

angelozerr opened this issue Jul 22, 2023 · 2 comments · Fixed by eclipse-lemminx/lemminx#1558
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
0.27.0

Comments

@angelozerr
Copy link
Contributor

With binary mode, XInclude cannot be activated.
@angelozerr angelozerr added the bug Something isn't working label Jul 22, 2023
@angelozerr angelozerr self-assigned this Jul 22, 2023
@angelozerr angelozerr added this to the 0.26.2 milestone Jul 22, 2023
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jul 22, 2023
@angelozerr
XInclude cannot be activated with binary mode #
3db0a6a 
Fixes redhat-developer/vscode-xml#922

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 22, 2023
Merged
@angelozerr
Copy link
Contributor Author

@datho7561 @JessicaJHee I created a quick PR eclipse-lemminx/lemminx#1558 but I have not tested, I don't know if it it will be enough

angelozerr added a commit to angelozerr/lemminx that referenced this issue Jul 22, 2023
@angelozerr
XInclude cannot be activated with binary mode #
6b989bd 
Fixes redhat-developer/vscode-xml#922

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 22, 2023
Closed
datho7561 pushed a commit to eclipse-lemminx/lemminx that referenced this issue Jul 24, 2023
@angelozerr @datho7561
XInclude cannot be activated with binary mode #
75091d1 
Fixes redhat-developer/vscode-xml#922

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

Thanks @datho7561 for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
IDE Cloudaptors
Archived in project
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

XInclude cannot be activated with binary mode angelozerr/lemminx
1 participant
@angelozerr