Add xml.java.home preference #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Jun 3, 2019
package.json
Outdated
| "string", | ||
| "null" | ||
| ], | ||
| "default": null |
There was a problem hiding this comment.
"description": "Specifies the folder path to the JDK (8 or more recent) used to launch the XML Language Server.\nOn Windows, backslashes must be escaped, i.e.\n"xml.java.home":"C:\\Program Files\\Java\\jdk1.8.0_161"",
"scope":"window"
NikolasKomonen
approved these changes
Jun 3, 2019
|
You also need to update https://github.com/redhat-developer/vscode-xml/blob/master/README.md#requirements and https://github.com/redhat-developer/vscode-xml/blob/master/README.md#supported-vs-code-settings (remove 0.6.0, add 0.7.0 note) |
|
@fbricon Updated |
fbricon
reviewed
Jun 4, 2019
README.md
Outdated
| Since 0.6.0: | ||
| * `xml.format.preservedNewLines`: Set the maximum amount of newlines between elements. Defaults to `2`. | ||
| Since 0.7.0: | ||
| * `xml.java.home`: Set the Java path required to run the XML Language Server. If not set, fallback to either `java.home` or the `JAVA_HOME` or `JDK_HOME` environment variables. |
There was a problem hiding this comment.
is it falls back or fallbacks?
to either the java.home preference, or the JAVA_HOME or JDK_HOME environment variables
Signed-off-by: David Kwon <dakwon@redhat.com>
fbricon
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
This change will check for the
xml.java.homepreference before checking thejava.homepreference.I also cleaned up
checkJavaRuntime()inrequirements.tsto make it a bit more readable.Please let me know if I should revert it to match the previous design.
Signed-off-by: David Kwon dakwon@redhat.com