-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry #427
Telemetry #427
Conversation
162d4e2
to
aac234d
Compare
45243da
to
e4b5bac
Compare
Going to rebase onto #421 once its merged, marking this PR as ready for review. |
633669a
to
f64fdb9
Compare
08f223b
to
09a9a53
Compare
I've observed that if I replace the default segment key with the debug one (ie. always use debug), rebuild vscode-commons, and install it along with this vscode-xml change then events are always logged, and it's working as expected. If not, I only seem to see events recorded when I'm debugging. |
Yes, as explained in https://github.com/redhat-developer/vscode-commons/blob/master/INSTRUCTIONS.md#optional-add-a-custom-segment-key-in-packagejson-file |
Can we track binary downloads (and failures)? |
The binary url response gets piped into a local file, and the 'finish' event seems like a good place to record that (for zip or binary case). See https://github.com/redhat-developer/vscode-xml/blob/master/src/server/binary/binaryServerStarter.ts#L232 . Failures can be tracked as well in downloadBinary() . @datho7561 , feel free to add these events (dowload success + failure) and we can test. |
a2f9549
to
9e9de80
Compare
I attached telemetry events to binary download success/failure. |
Implement telemetry. Please refer to `USAGE_DATA.md` to see which data is collected. Closes redhat-developer#415 Signed-off-by: David Thompson <davthomp@redhat.com>
9e9de80
to
e7c2926
Compare
I think we can merge this when ready. I can confirm that success/failure do get logged. |
Okay. I am ready to merge if you approve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let's get this in.
Implement telemetry. Please refer to
USAGE_DATA.md
to see which data is collected.Closes #415