Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry #427

Merged
Merged

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Feb 22, 2021

Implement telemetry. Please refer to USAGE_DATA.md to see which data is collected.
Closes #415

package.json Outdated Show resolved Hide resolved
@datho7561 datho7561 changed the title 415 telemetry after rebase Telemetry Feb 22, 2021
@datho7561 datho7561 force-pushed the 415-telemetry-after-rebase branch 3 times, most recently from 45243da to e4b5bac Compare February 24, 2021 16:09
@datho7561
Copy link
Contributor Author

Going to rebase onto #421 once its merged, marking this PR as ready for review.

@datho7561 datho7561 force-pushed the 415-telemetry-after-rebase branch 2 times, most recently from 633669a to f64fdb9 Compare February 24, 2021 21:41
src/telemetry.ts Outdated Show resolved Hide resolved
@datho7561 datho7561 force-pushed the 415-telemetry-after-rebase branch 4 times, most recently from 08f223b to 09a9a53 Compare February 25, 2021 15:50
@rgrunber
Copy link
Member

rgrunber commented Feb 25, 2021

I've observed that if I replace the default segment key with the debug one (ie. always use debug), rebuild vscode-commons, and install it along with this vscode-xml change then events are always logged, and it's working as expected.

If not, I only seem to see events recorded when I'm debugging.

@fbricon
Copy link
Collaborator

fbricon commented Mar 9, 2021

I've observed that if I replace the default segment key with the debug one (ie. always use debug), rebuild vscode-commons, and install it along with this vscode-xml change then events are always logged, and it's working as expected.

If not, I only seem to see events recorded when I'm debugging.

Yes, as explained in https://github.com/redhat-developer/vscode-commons/blob/master/INSTRUCTIONS.md#optional-add-a-custom-segment-key-in-packagejson-file

@fbricon
Copy link
Collaborator

fbricon commented Mar 9, 2021

Can we track binary downloads (and failures)?

@rgrunber
Copy link
Member

rgrunber commented Mar 9, 2021

The binary url response gets piped into a local file, and the 'finish' event seems like a good place to record that (for zip or binary case). See https://github.com/redhat-developer/vscode-xml/blob/master/src/server/binary/binaryServerStarter.ts#L232 . Failures can be tracked as well in downloadBinary() .

@datho7561 , feel free to add these events (dowload success + failure) and we can test.

@datho7561 datho7561 force-pushed the 415-telemetry-after-rebase branch 2 times, most recently from a2f9549 to 9e9de80 Compare March 9, 2021 15:24
@datho7561
Copy link
Contributor Author

I attached telemetry events to binary download success/failure.

@rgrunber rgrunber added this to the 0.16.0 milestone Mar 11, 2021
Implement telemetry.
Please refer to `USAGE_DATA.md` to see which data is collected.

Closes redhat-developer#415

Signed-off-by: David Thompson <davthomp@redhat.com>
@rgrunber
Copy link
Member

I think we can merge this when ready. I can confirm that success/failure do get logged.

@datho7561
Copy link
Contributor Author

Okay. I am ready to merge if you approve the PR.

@rgrunber rgrunber self-requested a review March 12, 2021 14:33
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's get this in.

@datho7561 datho7561 merged commit ee25f3a into redhat-developer:master Mar 12, 2021
@datho7561 datho7561 deleted the 415-telemetry-after-rebase branch March 12, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect Telemetry data
3 participants