Inject VS Code proxy settings into JVM args #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
416-inject-proxy-config
branch
2 times, most recently
from
daa021c to
1cdc71a
Compare
datho7561
commented
Apr 6, 2021
Interprets the `http.proxyHost` and `http.proxyAuthorization` settings in order to set up the JVM arguments or environment variables in order to configure the proxy for the language server. JVM arguments are used when running the Java server, and environment variables are used when running the binary server. This means if the proxy is configured through these settings in VS Code, then vscode-xml will download schemas through the proxy. While running the Java server, if the proxy is already configured in `xml.server.vmargs`, then the `http.proxyHost` and `http.proxyAuthorization` are ignored. Limitations: * If `http.proxyAuthorization` is used, it is assumed to be [Basic authentication](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization#directives), with a username/password pair, since the JVM expects a username/password pair. Requires eclipse-lemminx/lemminx#1012 Closes redhat-developer#416 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
416-inject-proxy-config
branch
from
1cdc71a to
cbfcc62
Compare
rgrunber
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interprets the
http.proxyHostandhttp.proxyAuthorizationsettings in order to set up the JVM arguments or environment variables in order to configure the proxy for the language server.JVM arguments are used when running the Java server, and environment variables are used when running the binary server.
This means if the proxy is configured through these settings in VS Code, then vscode-xml will download schemas through the proxy.
While running the Java server, if the proxy is already configured in
xml.server.vmargs, then thehttp.proxyHostandhttp.proxyAuthorizationare ignored.Limitations:
http.proxyAuthorizationis used, it is assumed to be Basic authentication, with a username/password pair, since the JVM expects a username/password pair.Requires eclipse-lemminx/lemminx#1012
Closes #416
Signed-off-by: David Thompson davthomp@redhat.com