Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented workspace trust interaction with resolveExternalEntities #546

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Documented workspace trust interaction with resolveExternalEntities #546

merged 1 commit into from
Jul 9, 2021

Conversation

AlexXuChen
Copy link
Contributor

Documented workspace trust interaction with resolveExternalEntities in README.md and Validation.md

References #537

Signed-off-by: Alexander Chen alchen@redhat.com

@datho7561 datho7561 self-requested a review July 9, 2021 13:29
datho7561
datho7561 requested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also document that it's disabled when the workspace isn't trusted in the package.json, under the configuration section

@AlexXuChen AlexXuChen mentioned this pull request Jul 9, 2021
Merged
datho7561
datho7561 requested changes Jul 9, 2021
View reviewed changes
docs/Validation.md Outdated Show resolved Hide resolved
datho7561
datho7561 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datho7561 datho7561 added this to the 0.17.1 milestone Jul 9, 2021
@AlexXuChen AlexXuChen merged commit 475372e into redhat-developer:master Jul 9, 2021
@AlexXuChen AlexXuChen deleted the issue537_v2 branch July 9, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexXuChen @datho7561