Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to download binaries from GitHub Releases. #685

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

rgrunber
Copy link
Member

  • Migrate LemMinX binary server from download.jboss.org to github.com
  • GitHub Release URL returns 302 and does not properly set Content-Type
    so we should handle these cases
  • Archive the zipped binaries, checksums and vsix as a temporary measure
    until GH Release API can be used

Signed-off-by: Roland Grunberg rgrunber@redhat.com

- Migrate LemMinX binary server from download.jboss.org to github.com
- GitHub Release URL returns 302 and does not properly set Content-Type
  so we should handle these cases
- Archive the zipped binaries, checksums and vsix as a temporary measure
  until GH Release API can be used

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Contributor

@angelozerr angelozerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelozerr angelozerr added this to the 0.19.2 milestone Mar 28, 2022
@angelozerr angelozerr merged commit 2b7e607 into redhat-developer:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants