Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMate grammar for *.dtd files #713

Merged
merged 1 commit into from
May 31, 2022

Conversation

angelozerr
Copy link
Contributor

TextMate grammar for *.dtd files

Fixes #313

Signed-off-by: azerr azerr@redhat.com

@angelozerr
Copy link
Contributor Author

Here a draft PR that I did in few minutes by using https://github.com/sebastienscout/atom-dtd-language/blob/master/grammars/dtd.cson :

image

It's just a start, but the textmate should be really improved.

package.json Show resolved Hide resolved
@angelozerr angelozerr marked this pull request as ready for review May 28, 2022 09:47
@angelozerr angelozerr requested a review from AlexXuChen May 28, 2022 09:47
Fixes redhat-developer#313

Signed-off-by: azerr <azerr@redhat.com>
Copy link
Contributor

@AlexXuChen AlexXuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelozerr angelozerr merged commit ca4da0d into redhat-developer:master May 31, 2022
@angelozerr
Copy link
Contributor Author

I merged the PR it is a good start, but it requires a lot of improvement. We will improve it step by step and if we have good result, we could try to contribute to vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextMate grammar for *.dtd files
2 participants