Also use VS Code proxy config for HTTPS on language server #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
735-https-proxy
branch
from
564cd7b to
0f80194
Compare
AlexXuChen
suggested changes
Jul 14, 2022
One part of redhat-developer#735 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
735-https-proxy
branch
from
0f80194 to
d9a45b2
Compare
rgrunber
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Looks good to me.
I also noticed this phrasing in VS Code settings :
http.proxy : The proxy setting to use. If not set, will be inherited from the http_proxy and https_proxy environment variables.
I'm guessing we don't support extracting those environment variables on the client side ?
No, there is no logic to directly access the environment variables to get this value. Maybe VS Code explicitly copies the value from the environment into the VS Code setting, but I find this unlikely. |
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One part of #735
Signed-off-by: David Thompson davthomp@redhat.com