Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Allowlist for chars in filenames to prevent illegal chars in uclude statements #33

Closed
soulcharmer opened this issue May 10, 2022 · 2 comments

Comments

@soulcharmer
Copy link

Recently, we got a filename into an include statement by accident that evaded newdoc's sanitization by using a weird Unicode apostrophe:

include::modules/security/proc_changing-a-user’s-clearance-level-within-the-defined-security-range-in-mls.adoc[leveloffset=+1]

it broke preview links in an MR

The RFE is to consider a limited allowlist of characters to be used in file names that will not clash with subsequent include statements.

@soulcharmer
Copy link
Author

[Marek] Note to self: use string.is_ascii() here

@msuchane
Copy link
Collaborator

This is now fixed in the 2.10.2 release. The module ID now replaces all non-ASCII characters with dashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants