Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openshift deployment files for react agent,streamlit #7

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

hemajv
Copy link
Contributor

@hemajv hemajv commented Nov 4, 2024

(Addresses #2)

This PR adds OpenShift templates to deploy the ReAct agent server and Streamlit web app. The PR also modifies the code to update logging of the agent's outputs to a hosted MLFlow instance rather than a local instance.

Copy link

@suppathak suppathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Hema. Added minor comments. Otherwise lgtm.👍🏼

@hemajv
Copy link
Contributor Author

hemajv commented Nov 5, 2024

Thank you Hema. Added minor comments. Otherwise lgtm.👍🏼

Thanks @suppathak, updated the PR!

@hemajv hemajv merged commit b7571c6 into redhat-et:main Nov 6, 2024
Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -0,0 +1,38 @@
apiVersion: v1
Copy link
Member

@Shreyanand Shreyanand Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit that can be addressed in a subsequent PR:
Can we add in the readme that the tool definition has to be updated in this configmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants