Introductions and cleanups #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
The extra parentheses are not required and are not idiomatic python Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
The standard import order is stdlib, 3rd party, internal with newline between each section. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Apart from the future import where print is a function, not a statement, fix
incorrect print formatting calls. Calls like print("%s" % (foo)) are subtly
broken, depending on the value of foo, since (foo) is not a tuple but really
syntactic no-op. The correct way to do that is to use print("%s" % (foo,))
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I'm working on building the Fedora base snap using imagefactory and I was
thinking that as a part of saying hello and getting to know the code better, I
would send some cleanups that I do as I go through the code-base.
I don't know the deployment requirements but I'm working under the assumption
that Python 2.7 is required (that is, no need to support Python 2.6 anymore).
Please let me know how this feels, I will have more as I learn how the code works.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com