Testing arcade controller w/ginkgo #4
Conversation
adams0619
changed the title
controllers/arcade_controller.go
Outdated
| @@ -121,7 +121,6 @@ func (r *ArcadeReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| For(&arcadev1alpha1.Arcade{}). | |||
| Owns(&appsv1.Deployment{}). | |||
| Owns(&corev1.Service{}). | |||
| Owns(&routev1.Route{}). | |||
There was a problem hiding this comment.
we're creating the Route in the controller; isn't this still required?
There was a problem hiding this comment.
Yeah, we are creating routes, but when testing with envtest, I have not yet found a way to add third party APIs as part of the test kube-apiserver's known CRDs... still looking into it though.
…erver and update tests
|
reviewing. 👀 |
| "context" | ||
| "time" | ||
|
|
||
| . "github.com/onsi/ginkgo" |
There was a problem hiding this comment.
Yes, the . imports ginkgo into the file block without requiring a qualified identifier when using functions or variables from that package... removing the need to always type something like ginkgo.BeforeSuite or gomega.Expect for every exported function or value that is used from that package.
| test: generate fmt vet manifests | ||
| go test ./... -coverprofile cover.out | ||
| mkdir -p $(ENVTEST_ASSETS_DIR) | ||
| test -f $(ENVTEST_ASSETS_DIR)/setup-envtest.sh || curl -sSLo $(ENVTEST_ASSETS_DIR)/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.6.3/hack/setup-envtest.sh |
There was a problem hiding this comment.
minor comment: any reason we shouldn't always download or never download (if the file is included in the repo)?
There was a problem hiding this comment.
The binaries used for testing like the kube-apiserver is big, at 180MB for just the server, this exceeds GitHub's file size limit of 100MB for individual files, so downloading on demand keeps things flexible without needing to introduce something like git-lfs. Likewise, since Operator-SDK 1.1.0+, this is included as part of the scaffolding by default, in the generated Makefile
PR to setup testing using
ginkgo, specifically:arcade_controller.go.setup-envtest.shfor setting up mock k8s environment forenvtestetcd,kubectl, andkube-apiserverif not preset withintestbinarcade-operatorinconfig/crd/bases/....Testing process:
Run tests by running
make testfrom the project root.