Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IsExistLinkInNS always returns false #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

y-young
Copy link

@y-young y-young commented Mar 14, 2023

No description provided.

@s1061123
Copy link
Collaborator

Thank you for the PR. Could you pelase explain why you need this change?

I'm not sure your case, so appreciated you share the example case (code) to us.

@y-young
Copy link
Author

y-young commented Mar 14, 2023

Could you pelase explain why you need this change?

It's obvious that the previous code did not return early in the if block, so the result = false statement is always executed even if the link exists, i.e. result is always false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants