Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator observability-operator (0.0.25) #3084

Merged

Conversation

sthaha
Copy link
Contributor

@sthaha sthaha commented Aug 14, 2023

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description of the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@openshift-ci openshift-ci bot added openshift-operator needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

Hi @sthaha. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added authorized-changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@github-actions
Copy link
Contributor

Dear @sthaha,
Some errors and/or warnings were found while doing the check of your operator (observability-operator/0.0.25) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (observability-operator.v0.0.25) csv.Metadata.Annotations["categories"] value Observability is not in the set of custom categories
⚠️ Value monitoring.rhobs/v1, Kind=Alertmanager: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=PrometheusAgent: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=ScrapeConfig: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=ThanosRuler: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=ServiceMonitor: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=AlertmanagerConfig: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=PodMonitor: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=Probe: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=Prometheus: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=PrometheusRule: provided API should have an example annotation
⚠️ Value : (observability-operator.v0.0.25) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value observability-operator.v0.0.25: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[2].Rules[13]"])
⚠️ Value observability-operator.v0.0.25: owned CRD "alertmanagerconfigs.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "alertmanagers.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "monitoringstacks.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "podmonitors.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "probes.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheusagents.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheuses.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheusrules.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "scrapeconfigs.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "servicemonitors.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "thanosqueriers.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "thanosrulers.monitoring.rhobs" has an empty description

@github-actions
Copy link
Contributor

Dear @sthaha,
Some errors and/or warnings were found while doing the check of your operator (observability-operator/0.0.25) against the entire suite of validators for Operator Framework with Operator-SDK version v1.30.0 and the command $ operator-sdk bundle validate <bundle-path> --select-optional suite=operatorframework.

Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.

Type Message
🐛 Value : (observability-operator.v0.0.25) csv.Metadata.Annotations["categories"] value Observability is not in the set of custom categories
⚠️ Value monitoring.rhobs/v1, Kind=Alertmanager: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=PodMonitor: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=Prometheus: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=AlertmanagerConfig: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=Probe: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=PrometheusAgent: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=PrometheusRule: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1alpha1, Kind=ScrapeConfig: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=ServiceMonitor: provided API should have an example annotation
⚠️ Value monitoring.rhobs/v1, Kind=ThanosRuler: provided API should have an example annotation
⚠️ Value : (observability-operator.v0.0.25) csv.Spec.minKubeVersion is not informed. It is recommended you provide this information. Otherwise, it would mean that your operator project can be distributed and installed in any cluster version available, which is not necessarily the case for all projects.
⚠️ Value observability-operator.v0.0.25: this bundle is using APIs which were deprecated and removed in v1.25. More info: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25. Migrate the API(s) for poddisruptionbudgets: (["ClusterServiceVersion.Spec.InstallStrategy.StrategySpec.ClusterPermissions[2].Rules[13]"])
⚠️ Value observability-operator.v0.0.25: owned CRD "alertmanagerconfigs.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "alertmanagers.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "monitoringstacks.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "podmonitors.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "probes.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheusagents.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheuses.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "prometheusrules.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "scrapeconfigs.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "servicemonitors.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "thanosqueriers.monitoring.rhobs" has an empty description
⚠️ Value observability-operator.v0.0.25: owned CRD "thanosrulers.monitoring.rhobs" has an empty description

Signed-off-by: Sunil Thaha <sthaha@redhat.com>
@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation
Copy link
Collaborator

/merge possible

@framework-automation framework-automation merged commit 6bc5e3a into redhat-openshift-ecosystem:main Aug 14, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants