Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating operator-sdk to 1.28.0 #941

Merged
merged 1 commit into from
Apr 6, 2023
Merged

updating operator-sdk to 1.28.0 #941

merged 1 commit into from
Apr 6, 2023

Conversation

acornett21
Copy link
Contributor

  • Updating operator-sdk to 1.28.0 to have latest scorecard image changes
  • Using the same dependencies as operator-sdk, so our tests continue to work properly

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21 acornett21 requested review from bcrochet and komish March 30, 2023 21:21
@openshift-ci openshift-ci bot requested a review from jomkz March 30, 2023 21:21
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@acornett21
Copy link
Contributor Author

@tkrishtop Here is this PR, it's been on my todo list for a few weeks now. Hope this helps!

@coveralls
Copy link

coveralls commented Mar 30, 2023

Coverage Status

coverage: 95.968%. remained the same
when pulling eaec71e on acornett21:main
into e4eba70 on redhat-openshift-ecosystem:main.

@komish
Copy link
Contributor

komish commented Apr 3, 2023

check workload preflight-green

1 similar comment
@tkrishtop
Copy link
Contributor

check workload preflight-green

Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@komish
Copy link
Contributor

komish commented Apr 3, 2023

@acornett21 the DCI failure is reporting that simple demo operator failed scorecard tests.
[EDIT] Looks like a context deadline exceeded situation.

@komish komish closed this Apr 3, 2023
@komish komish reopened this Apr 3, 2023
@komish
Copy link
Contributor

komish commented Apr 3, 2023

@tkrishtop We're seeing timeouts for Scorecard tests. @acornett21 pointed out that the operator-sdk image we're using is changing which might be the source of the problem.

Do you need to make new images available withing the infrastructure where preflight-green runs?

Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 5dc193c into redhat-openshift-ecosystem:main Apr 6, 2023
@tkrishtop
Copy link
Contributor

hi @komish sorry, I've seen your comment quite late. I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants