add nodeName as a new parameter to support MNO usecase #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nishant-parekh
commented
Oct 7, 2024
nishant-parekh
commented
- Pass in the nodeName with a running GM deployment for testing
- Use this nodeName to identify the correct linuxptp-daemon pod to use in an MNO deployment
- NodeName is stored part of the collectionConstructor and ContainerExecContext available for any collector under use
nishant-parekh
force-pushed
the
mno_support
branch
from
2e2868a to
97ce73a
Compare
nishant-parekh
changed the title
* Pass in the nodeName with a running GM deployment for testing * Use this nodeName to identify the correct linuxptp-daemon pod to use in an MNO deployment * NodeName is stored part of the collectionConstructor available for any collector under use * fix linter issues Signed-off-by: Nishant Parekh <nparekh@redhat.com>
nishant-parekh
force-pushed
the
mno_support
branch
from
97ce73a to
0112616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.