VM verification and Logs #896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebattat
force-pushed
the
vm_verification_log
branch
from
cd4e5f0
to
0d14b00
Compare
RobertKrawitz
requested changes
Sep 19, 2024
| self.creds = self.authenticate() | ||
| self.service = build('drive', 'v3', credentials=self.creds) | ||
|
|
||
| def authenticate(self): | ||
| """ | ||
| Authenticates and returns credentials using token.json or interactive login. | ||
| Authenticates and returns credentials.json using token.json.json or interactive login. |
There was a problem hiding this comment.
Duplicate ".json" (in token.json).
Comment on lines
+11
to
+19
| if os.path.exists('token.json.json'): | ||
| creds = Credentials.from_authorized_user_file('token.json.json', SCOPES) | ||
| else: | ||
| flow = InstalledAppFlow.from_client_secrets_file('credentials.json.json', SCOPES) | ||
| creds = flow.run_local_server(port=0) | ||
|
|
||
| # Save the credentials.json for future runs | ||
| with open('token.json.json', 'w') as token: | ||
| token.write(creds.to_json()) |
There was a problem hiding this comment.
token.json.json should be token.json (likewise credentials)
| command = f"oc adm must-gather --image=registry.redhat.io/odf4/odf-must-gather-rhel9:v{odf_version} --dest-dir={destination_path}/odf-must-gather-rhel9-v{odf_version}" | ||
| self.run(command) | ||
| except Exception as e: | ||
| raise RuntimeError(f"Failed to generate ODF must-gather logs: {e}") |
There was a problem hiding this comment.
Do you need to clean up anything if this fails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
For security reasons, all pull requests need to be approved first before running any automated CI