Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cloud is not set to provisioned=True if schedule is removed while move is in progress #361

Open
grafuls opened this issue Feb 2, 2021 · 2 comments

Comments

@grafuls
Copy link
Contributor

grafuls commented Feb 2, 2021

Describe the bug
There is a chance we might want to remove a schedule for a host moving into a new cloud while the move is still in progress.
E.g.: All hosts on that cloud have already moved but 1 host is failing on the move step due to lack of network connectivity or broken state. If the schedule is removed, Quads has no chance to mark the cloud as provisioned=True due to the fact that the M&R action was not completed successfully.
The consequence of this is that the cloud will never go into validation

To Reproduce
Steps to reproduce the behavior:
0. disable all crons

  1. create new schedule for several hosts
  2. setup one of those hosts to fail on move and rebuild (SSH disabled)
  3. run M&R and have it move all host to the new cloud while failing on the one setup for fail
  4. once the failed host is the only one left to move, remove the schedule for that host
  5. run validate_env and notice no clouds are available for validation

Expected behavior
Cloud should go into validation despite host schedule being removed.

@sadsfae
Copy link
Member

sadsfae commented Sep 26, 2024

Closing this, not sure we've seen this for a few years now and we've been in this scenario a few times already.

@sadsfae sadsfae closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in QUADS 1.1 and 2.0 Series Sep 26, 2024
@sadsfae sadsfae reopened this Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Done to To Do in QUADS 1.1 and 2.0 Series Oct 1, 2024
@sadsfae sadsfae moved this from To do to To Do: High Priority and Bugs in QUADS 2.0 Series Oct 1, 2024
@sadsfae sadsfae moved this from To do to To Do: High Priority and Bugs in QUADS 2.1 Series Oct 1, 2024
@sadsfae
Copy link
Member

sadsfae commented Oct 1, 2024

This can be worked around by updating the provisioned boolean for assignments in Postgres for the affected assignment.

quads=# update assignments set provisioned = true where id = 54;
UPDATE 1

Documented here: https://github.com/redhat-performance/quads?tab=readme-ov-file#validating-after-removing-hosts

@sadsfae sadsfae moved this from To Do: High Priority and Bugs to To do in QUADS 2.0 Series Oct 1, 2024
@sadsfae sadsfae moved this from To Do: High Priority and Bugs to To do in QUADS 2.1 Series Oct 1, 2024
sadsfae added a commit that referenced this issue Oct 1, 2024
related-to: #361
Change-Id: Iec8b8316413f17613c0feec299b865aec20a925a
sadsfae added a commit that referenced this issue Oct 1, 2024
related-to: #361
Change-Id: Ifb950db78cdd238f098187b9fd67b62c28593ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants