Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udev-rules): keep network device naming scheme on upgrade #31

Closed
wants to merge 1 commit into from

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Oct 5, 2023

(Cherry-picked commit: 2fc6cd37e61e53333d57164eee79e90c6adcade6)

Resolves: RHEL-9480

(Cherry-picked commit: 2fc6cd37e61e53333d57164eee79e90c6adcade6)

Resolves: RHEL-9480
@pvalena
Copy link
Contributor Author

pvalena commented Oct 5, 2023

@lnykryn PTAL.

@lnykryn
Copy link
Member

lnykryn commented Nov 14, 2023

Chmm, I am not thrilled about this; I can imagine where a user depends on this broken behaviour and mounts some network fs via the kernel name of the device. I think this fix makes sense upstream, but I am really worried about putting this in the last minor version of rhel8.

@pvalena
Copy link
Contributor Author

pvalena commented Nov 14, 2023

It's just "hostonly", so I hoped it shouldn't do anything apart from fixing the behaviour, right? Maybe it deserves a RN. I'm not sure why would someone depend on missing this behaviour, and expect it to persist (RHELDOCS-16507#comment) The file does not exist by default, right?

Based on the ticket [1] I thought this would be the correct fix, especially if it's in the documentation.

[1] https://issues.redhat.com/browse/RHEL-9480

@lnykryn
Copy link
Member

lnykryn commented Nov 14, 2023

Can you please skip this one for now, I need some time to think about this. And hostonly is the default and in the setup I have mentioned you definitely have hostonly initrd

@pvalena pvalena marked this pull request as draft November 14, 2023 15:56
@pvalena
Copy link
Contributor Author

pvalena commented Jan 28, 2024

Let's drop this, as there're is no demand to resolve this issue.

@pvalena pvalena closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants