Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for file retrival, use random file names #511

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Wait for file retrival, use random file names #511

merged 6 commits into from
Dec 19, 2024
+13 −4

Conversation

betoredhat
Copy link
Contributor

@betoredhat betoredhat commented Dec 18, 2024 •
edited
Loading

SUMMARY

This used to fail the first time the http_store pod was created, as there is a short time between the pod creation and attempting to get the file.

Also in parallel executions, another deployment could modify the content of the test file, so creating random file names,

ISSUE TYPE
  • nominal change
Tests

@betoredhat betoredhat requested a review from a team as a code owner December 18, 2024 20:59
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/cede23ed48714a0781520bf41c4cb187

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 28s

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2024

from change #511:

@betoredhat betoredhat changed the title Wait for file retrival Wait for file retrival, use random file names Dec 18, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/6d6632d688674857b801cf5bd3a451a4

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 17s

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2024

from change #511:

@betoredhat
Copy link
Contributor Author

restest

@betoredhat
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7f9d6beb3abe4978a38e9875cb678398

✔️ dci-rpm-build-el8 SUCCESS in 2m 47s
✔️ dci-rpm-build-el9 SUCCESS in 2m 27s

@betoredhat betoredhat force-pushed the retry_get branch 2 times, most recently from a811752 to 3378cfc Compare December 18, 2024 22:05
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/9fa42cdb8dd34d34b7e5a2475ad43eca

✔️ dci-rpm-build-el8 SUCCESS in 2m 41s
✔️ dci-rpm-build-el9 SUCCESS in 2m 33s

@dcibot
Copy link
Collaborator

dcibot commented Dec 18, 2024

from change #511:

pierreblanc
pierreblanc previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@pierreblanc pierreblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ba4d4f1588dc449a94a05d11ec7e4174

✔️ dci-rpm-build-el8 SUCCESS in 2m 46s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/218f63fa965e417e8e11a397ade59fb3

✔️ dci-rpm-build-el8 SUCCESS in 2m 58s
✔️ dci-rpm-build-el9 SUCCESS in 2m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/699481bb479a4218ac552790c7325a82

✔️ dci-rpm-build-el8 SUCCESS in 2m 55s
✔️ dci-rpm-build-el9 SUCCESS in 2m 50s

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

from change #511:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/ae4329b6d22143e9af84a07516ff202d

✔️ dci-rpm-build-el8 SUCCESS in 2m 45s
✔️ dci-rpm-build-el9 SUCCESS in 2m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2a56cd6b74414ffda68fc7a6cc03ec53

✔️ dci-rpm-build-el8 SUCCESS in 2m 51s
✔️ dci-rpm-build-el9 SUCCESS in 2m 21s

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

from change #511:

@betoredhat
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/fc7557b920854eed98f5bb7459cb7e69

✔️ dci-rpm-build-el8 SUCCESS in 2m 50s
✔️ dci-rpm-build-el9 SUCCESS in 2m 28s

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

from change #511:

ramperher
ramperher approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betoredhat betoredhat added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e2ac103 Dec 19, 2024
7 checks passed
@betoredhat betoredhat deleted the retry_get branch December 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrishtop tkrishtop tkrishtop left review comments

@tonyskapunk tonyskapunk tonyskapunk left review comments

@nocturnalastro nocturnalastro nocturnalastro approved these changes

@ramperher ramperher ramperher approved these changes

@pierreblanc pierreblanc pierreblanc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@betoredhat @dcibot @tonyskapunk @ramperher @nocturnalastro @pierreblanc @tkrishtop