This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add Google image formatting to CLI #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyunari
reviewed
Nov 17, 2022
| @@ -116,7 +116,7 @@ def format_image(image: dict[str, str]) -> dict[str, str]: | |||
| """ | |||
|
|
|||
| arch = image["architecture"] | |||
| image_id = image["id"] | |||
| image_id = image["name"] | |||
There was a problem hiding this comment.
Yeah while the GCP image properties do contain an "ID" tag it's not actually used to create a VM instance. The "name" in a Google image is what we consider the image id in AWS and Azure.. This is once again one of those weird differences between cloud providers.. tbh. I've only noticed when I was running the live CLI tests. Turns out, the "normalize_google_images" method doesn't even parse the id property.
There was a problem hiding this comment.
Btw. fixed this in the Schema definition for sake of consistency!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #106