Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fix missing azure images test coverage #32

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

major
Copy link
Member

@major major commented Oct 10, 2022

Branch coverage was missing for retrieving all Azure images when latest was not set.

Also trim some trailing space in the GCP header in the config file. 🧹

Signed-off-by: Major Hayden major@redhat.com

Branch coverage was missing for retrieving all Azure images when
`latest` was not set.

Also trim some trailing space in the GCP header in the config file. 🧹

Signed-off-by: Major Hayden <major@redhat.com>
Copy link
Member

@F-X64 F-X64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Isn't 100% test coverage a required part of our pre-commit hook?

@major
Copy link
Member Author

major commented Oct 10, 2022

LGTM. Isn't 100% test coverage a required part of our pre-commit hook?

I thought so, but perhaps this deserves another looksee. 👀

@major major merged commit 4bf70df into main Oct 10, 2022
@major major deleted the missing-test-coverage branch October 10, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants