This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add AWS image name parser #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse additional information about AWS images using their name. Fixes #34 Signed-off-by: Major Hayden <major@redhat.com>
major
force-pushed
the
parse-aws-image-names
branch
from
82e4eb9 to
da2f223
Compare
F-X64
approved these changes
Oct 11, 2022
|
@FKolwa Hah, thanks. I kept thinking I could get creative with splitting on dashes and underscores, but then I realized that it would be easier with a regex of some sort. 🤷🏻♂️ |
|
Btw. Who decides about this naming strategy? Is it Red Hat? Is it Amazon? Is there some guarantee that future image names will adhere to this or could we end up with a "rhel-9.1_amazing_blueberry-HVM-HOURLY-2023" at some point? |
|
That's a good question. Based on what I've seen so far for hourly/cloud access, it looks like we are the ones that decide. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse additional information about AWS images using their name.
Fixes #34
Signed-off-by: Major Hayden major@redhat.com