This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add Google Auth to workflow #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-X64
force-pushed
the
add-google-oidc-auth
branch
from
aa7f338 to
abf93bb
Compare
F-X64
force-pushed
the
add-google-oidc-auth
branch
from
abf93bb to
e69a98a
Compare
major
approved these changes
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to dump the Google service credentials into a local file before running the e2e tests.
Github enabled Open ID Connect last year.
In short:
We can use our credentials as secrets to authenticate with Google, return a one time token (1 hour validity) and use this token to run out API requests.
This PR uses the existing Google service account key to return this token but I will open up a follow up task to move to Workload Identity Federation instead.
Github supports OIDC for Azure, AWS and Google as well as external credential providers like HashiCorp's Valut so it might be worth to spend some time and setup a unified authentication system.