Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Draft: Proposal to enable ZST encoded archives loaded by the transformer #574

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft: Proposal to enable ZST encoded archives loaded by the transformer #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/transformer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ jobs:

- name: Upload to S3
run: |
s3cmd sync --acl-public --delete-removed --mime-type application/json \
s3cmd sync --acl-public --mime-type application/json \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why you think this could be a good idea. But we actually need to remove the files that are not uploaded, otherwise we can't filter things in the transformer, since they will still be on S3 :) WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I had no idea. Yes that makes sense to me.

$(pwd)/images/ s3://cloudx-json-bucket/images/
Loading