This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Get more data from GCP about images #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major
force-pushed
the
get-more-gcp-data
branch
from
653e961 to
4f48484
Compare
The original proof of concept functions only retrieved the name of the image from GCP but no additional data was included. This patch updates those methods by adding in pertinent information from Google's image list object that could be useful in the locator. Google returns an unusual object (with more objects under attributes) that is difficult to parse, so it required an additional function to normalize the data and return it similarly to how we handle AWS and Azure. Signed-off-by: Major Hayden <major@redhat.com>
F-X64
force-pushed
the
get-more-gcp-data
branch
from
4f48484 to
5e6eea4
Compare
|
@major had to manually rebase to fix merge conflicts. I'll go ahead and merge once tests have passed. |
|
Thanks, @FKolwa! 🫂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original proof of concept functions only retrieved the name of the image from GCP but no additional data was included. This patch updates those methods by adding in pertinent information from Google's image list object that could be useful in the locator.
Google returns an unusual object (with more objects under attributes) that is difficult to parse, so it required an additional function to normalize the data and return it similarly to how we handle AWS and Azure.
Fixes #62
Signed-off-by: Major Hayden major@redhat.com