This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
V2 list version by provider #592 #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janine Olear <pninak@web.de>
Signed-off-by: Janine Olear <pninak@web.de>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 9 9
Lines 503 528 +25
Branches 108 116 +8
==========================================
+ Hits 463 486 +23
- Misses 21 22 +1
- Partials 19 20 +1
☔ View full report in Codecov by Sentry. |
F-X64
approved these changes
Jul 26, 2023
|
|
||
| @no_type_check | ||
| def run(self, data: type[Transformer]) -> list: | ||
| # TODO: check that its the v2 data entries. |
There was a problem hiding this comment.
Nitpick, but I assume that this should have been "# NOTE: Verify that the data is from api v2." as well?
There was a problem hiding this comment.
Oh haha - yes I will change this 😄
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
v2_list_version_#592
branch
from
9707b1c to
0ac79b4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #592